ref(tags): Fix custom tags issue

[priscilawebdev]

closes: https://app.asana.com/0/1182975495223914/1197541196070295

Description: The UI or the event json is not showing the keys of the custom tags that were left empty or exceeded in the desired length.

it looks like below:

Chrome

Mozilla:

Safari:

[github-actions]

size-limit report

Path	Size
public/app.js	239.1 KB (-0.01% 🔽)
public/vendor.js	445.86 KB (+0.01% 🔺)

[markstory]

It would be good to add a test for the Event serializer covering this fix.

[jan-auer]

Thanks, this was still missing in the PR. There are tests covering this, but the tests were incomplete. They are now complete.

[jan-auer]

Further tests are not possible at the moment as they will require on an updated version of sentry-relay which can only be released after getsentry/relay#808, which needs to wait on getsentry/snuba#1419.

@priscilawebdev This still needs to account for null in tag keys. After updating to the above Relay PR, you can test with the following test event:

{
  "tags": {
    "a": "", 
    "": "b",
    "??": "c"
  }
}

This renders the following UI:

And also creates an error on the console:

Warning: Encountered two children with the same key, null.

Also, I'm 👍 to @markstory's suggestion to ship refactorings in a separate PR.

[billyvg]

The frontend bits LGTM