Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax jest test timeout #30501

Merged
merged 1 commit into from
Dec 8, 2021
Merged

Relax jest test timeout #30501

merged 1 commit into from
Dec 8, 2021

Conversation

chadwhitacre
Copy link
Member

This is a bandaid to get master back to green ASAP (#30500). Really these tests should not be taking this long. Here are local runs for comparison:

 PASS  tests/js/spec/views/dashboardsV2/detail.spec.jsx (7.255 s)
  Dashboards > Detail
    prebuilt dashboards
      ✓ can delete (334 ms)
      ✓ can rename and save (132 ms)
      ✓ disables buttons based on features (45 ms)
    custom dashboards
      ✓ can remove widgets (278 ms)
      ✓ can enter edit mode for widgets (660 ms) <------------------------------------- vs. 5000+
      ✓ does not update if api update fails (252 ms)
      ✓ shows add wiget option (426 ms)
      ✓ hides add widget option (227 ms)
      ✓ hides and shows breadcrumbs based on feature (271 ms)
      ✓ enters edit mode when given a new widget in location query (113 ms)
      ✓ enters view mode when not given a new widget in location query (107 ms)
      ✓ can add library widgets (309 ms)
      ✓ disables add library widgets when max widgets reached (73 ms)
      ✓ adds an Issue widget to the dashboard (416 ms)

 PASS  tests/js/spec/views/alerts/create.spec.jsx (9.255 s)
  ProjectAlertsCreate
    ✓ redirects to wizard (439 ms)
    Issue Alert
      ✓ loads default values (111 ms)
      ✓ can remove filters, conditions and actions (1615 ms) <------------------------- vs. 5000+
      ✓ updates values and saves (1403 ms)

Copy link
Member

@shruthilayaj shruthilayaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (I'd take my approval with a grain of salt tho). I'm trying to get the dashboard one to be un-flakey in an another PR like you mentioned!

@chadwhitacre chadwhitacre merged commit 8d5dcfe into master Dec 8, 2021
@chadwhitacre chadwhitacre deleted the cwlw/relax-jest-test-timeout branch December 8, 2021 16:55
@chadwhitacre
Copy link
Member Author

A little salt goes a long way. Merged! 💃

@github-actions github-actions bot locked and limited conversation to collaborators Dec 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants