feat(helpful-event): Temporarily remove trace.sampled from sort #53065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #53065 +/- ##
==========================================
- Coverage 79.47% 79.47% -0.01%
==========================================
Files 4935 4935
Lines 207560 207560
Branches 35438 35438
==========================================
- Hits 164959 164955 -4
- Misses 37569 37571 +2
- Partials 5032 5034 +2
|
barkbarkimashark
approved these changes
Jul 18, 2023
malwilley
added a commit
that referenced
this pull request
Aug 1, 2023
`trace.sampled` values from the last 7 days should now be reliable, so we can go back to sorting on them. See #53065 for why it was temporarily removed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the changes in getsentry/relay#2290,
trace.sampledis being applied more conservatively to events. With the current sorting logic, we may be selecting events FROM before the relay change because they were the only ones withtrace.sampled: true.Since we only check the last 7 days for the
/helpfulendpoint, we can add this line back in once the relay change is 7 days old.