Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(spans): Handle span schema v1 from Relay #57284

Merged
merged 6 commits into from
Oct 3, 2023
Merged

feat(spans): Handle span schema v1 from Relay #57284

merged 6 commits into from
Oct 3, 2023

Conversation

phacops
Copy link
Contributor

@phacops phacops commented Oct 2, 2023

@phacops phacops requested review from jjbayer, dbanda and nikhars October 2, 2023 15:04
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 2, 2023
nikhars
nikhars approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@nikhars nikhars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me. Left a comment for clarification.

src/sentry/spans/consumers/process/factory.py Outdated Show resolved Hide resolved
Zylphrex
Zylphrex approved these changes Oct 3, 2023
View reviewed changes
src/sentry/spans/consumers/process/factory.py Outdated Show resolved Hide resolved
src/sentry/spans/consumers/process/factory.py Show resolved Hide resolved
@phacops phacops enabled auto-merge (squash) October 3, 2023 21:53
@phacops phacops disabled auto-merge October 3, 2023 22:11
@phacops phacops merged commit 41f334e into master Oct 3, 2023
@phacops phacops deleted the pierre/spans-handle-new-schema-from-relay branch October 3, 2023 22:30
@jjbayer jjbayer mentioned this pull request Oct 4, 2023
Merged
jjbayer added a commit to getsentry/relay that referenced this pull request Oct 4, 2023
@jjbayer
ref(spans): JSON Kafka message with metadata (#2556)
600efba 
This PR makes the following changes to the relay -> sentry kafka schema
for spans:

* [breaking change] Encode the payload as JSON, not msgpack. Msgpack
should only be used for payloads that contain (partial) binary data.
* Add the fields `organization_id` and `retention_days` so the consumer
does not have to look them up.
* [through #2555] New field `span.sentry_tags` can be used instead of
`span.data`. It now contains the same keys as expected by snuba. The
values are guaranteed to be strings.
* Some extra validation to make sure we do not send corrupted data.

Sentry counterpart: getsentry/sentry#57284
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nikhars nikhars nikhars approved these changes

@Zylphrex Zylphrex Zylphrex approved these changes

@jjbayer jjbayer Awaiting requested review from jjbayer

@dbanda dbanda Awaiting requested review from dbanda

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phacops @Zylphrex @nikhars