Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow to select v8 in Loader Script #73835

Merged
merged 1 commit into from
Jul 9, 2024
Merged

feat: Allow to select v8 in Loader Script #73835

merged 1 commit into from
Jul 9, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Jul 4, 2024

This adds a feature flag organizations:js-sdj-loader-v8 that can be set that will add 8.x to the selectable options for the Loader Script.

Part of getsentry/sentry-javascript#12187

@mydea mydea requested review from lforst and AbhiPrasad July 4, 2024 14:11
@mydea mydea self-assigned this Jul 4, 2024
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 4, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.11%. Comparing base (ba90407) to head (0d2c6ba).
Report is 14 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #73835      +/-   ##
==========================================
+ Coverage   78.08%   78.11%   +0.03%     
==========================================
  Files        6659     6659              
  Lines      297923   297928       +5     
  Branches    51259    51260       +1     
==========================================
+ Hits       232639   232733      +94     
+ Misses      58986    58907      -79     
+ Partials     6298     6288      -10
Files Coverage Δ
src/sentry/features/temporary.py 100.00% <100.00%> (ø)
src/sentry/loader/browsersdkversion.py 83.07% <66.66%> (-2.17%) ⬇️

... and 25 files with indirect coverage changes

s1gr1d
s1gr1d reviewed Jul 8, 2024
View reviewed changes
src/sentry/loader/browsersdkversion.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to change line 73 in this file? It think is not giving back v8.

Copy link
Member

@lforst lforst Jul 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is by design :) We don't want to put people who are currently on latest (7.x), on 8.x because that may break them.

lforst
lforst approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way the feature flag is set up will not prevent anybody to manually put themselve onto v8 but that's probably fine.

@mydea
Copy link
Member Author

mydea commented Jul 9, 2024

The way the feature flag is set up will not prevent anybody to manually put themselve onto v8 but that's probably fine.

Jup, but I think this is OK - honestly if somebody does that manually, any potential problems (that we don't really forsee anyhow) are their problem 😅

@mydea mydea force-pushed the fn/loader-v8-select branch from 0d2c6ba to f5f9891 Compare July 9, 2024 08:23
@mydea mydea marked this pull request as ready for review July 9, 2024 08:23
@mydea mydea merged commit 12daf60 into master Jul 9, 2024
48 of 49 checks passed
@mydea mydea deleted the fn/loader-v8-select branch July 9, 2024 10:38
priscilawebdev pushed a commit that referenced this pull request Jul 11, 2024
@mydea @priscilawebdev
feat: Allow to select v8 in Loader Script (#73835)
a48999a 
This adds a feature flag `organizations:js-sdj-loader-v8` that can be
set that will add `8.x` to the selectable options for the Loader Script.

Part of getsentry/sentry-javascript#12187
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@s1gr1d s1gr1d s1gr1d left review comments

@lforst lforst lforst approved these changes

@AbhiPrasad AbhiPrasad Awaiting requested review from AbhiPrasad

Assignees

@mydea mydea

Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mydea @lforst @s1gr1d