Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(insights): add geo selector mobile module #76196

Merged
merged 4 commits into from
Sep 4, 2024

Conversation

DominikB2014
Copy link
Contributor

@DominikB2014 DominikB2014 commented Aug 14, 2024

work towards #75230

Add feature flagged geo region selector to mobile screens module (next to device.class filters)

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Aug 14, 2024
Copy link

codecov bot commented Aug 15, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
7667 1 7666 0
View the top 1 failed tests by shortest run time
useReplayData should incrementally load attachments and errors�useReplayData should incrementally load attachments and errors
Stack Traces | 0.168s run time
Error: expect(received).toStrictEqual(expected) // deep equality

- Expected - 2
+ Received + 23

@@ -1,8 +1,29 @@
- ObjectContaining {
- "attachments": Array [],
+ Object {
+ "attachments": Array [
+ Object {
+ "timestamp": 1672592400000,
+ "type": 0,
+ },
+ Object {
+ "timestamp": 1672592400000,
+ "type": 1,
+ },
+ Object {
+ "data": Object {
+ "height": 600,
+ "href": "http://localhost/",
+ "width": 800,
+ },
+ "timestamp": 1672592400000,
+ "type": 4,
+ },
+ ],
"errors": Array [],
+ "fetchError": undefined,
+ "fetching": true,
+ "onRetry": [Function anonymous],
"projectSlug": "project-slug",
"replayRecord": Object {
"activity": 0,
"browser": Object {
"name": "Other",
at Object.<anonymous> (.../replays/hooks/useReplayData.spec.tsx:430:28)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@DominikB2014 DominikB2014 requested a review from markushi August 15, 2024 18:54
@DominikB2014 DominikB2014 marked this pull request as ready for review August 15, 2024 18:54
@DominikB2014 DominikB2014 requested a review from a team as a code owner August 15, 2024 18:54
Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DominikB2014 DominikB2014 merged commit 34aed98 into master Sep 4, 2024
42 checks passed
@DominikB2014 DominikB2014 deleted the DominikB2014/geo-filter-mobile branch September 4, 2024 15:29
@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants