-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(breadcrumbs): Fix breadcrumbs styles + navigation #76207
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ 8 Tests Failed:
View the top 3 failed tests by shortest run timeBreadcrumbsDataSection can switch between display time formats�BreadcrumbsDataSection can switch between display time formats BreadcrumbsDataSection renders a summary of breadcrumbs with a button to view them all�BreadcrumbsDataSection renders a summary of breadcrumbs with a button to view them all BreadcrumbsDrawer allows sort dropdown to affect displayed crumbs�BreadcrumbsDrawer allows sort dropdown to affect displayed crumbs To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
scttcper
approved these changes
Aug 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a design approved sticky header to the breadcrumb drawer:
After chatting with Vu also made some changes so align the drawer header and sticky header in the new UI:

(This involved updating some border colors and spacing)
Lastly a few more bug fixes for breadcrumbs:
Applying

meta
for HTTP and Exception crumbs:Wrapping unformatted SQL

fixed.virtualization.mov