Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(explore): Use sort type from discover #76220

Merged
merged 3 commits into from
Aug 15, 2024

Conversation

Zylphrex
Copy link
Member

Discover already defines a Sort type, so let's try to reuse that instead of redefining our own.

Discover already defines a `Sort` type, so let's try to reuse that instead of
redefining our own.
@Zylphrex Zylphrex requested a review from a team as a code owner August 14, 2024 21:19
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Aug 14, 2024
Copy link
Member

@wmak wmak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Zylphrex Zylphrex merged commit 87c723a into master Aug 15, 2024
41 checks passed
@Zylphrex Zylphrex deleted the txiao/ref/use-sort-type-from-discover-in-explore branch August 15, 2024 16:17
Copy link

sentry-io bot commented Aug 19, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Error: useLocation() may be used only in the context of a component. useLocation(useLocation.tsx) View Issue
  • ‼️ Error: useLocation() may be used only in the context of a component. useLocation(useLocation.tsx) View Issue

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants