Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(uptime): Always pass span_id from check result to occurrence #76227

Conversation

evanpurkhiser
Copy link
Member

No description provided.

@evanpurkhiser evanpurkhiser requested a review from a team August 14, 2024 21:52
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 14, 2024
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/fix-uptime-always-pass-span-id-from-check-result-to-occurrence branch from 48fa14b to e908ae0 Compare August 14, 2024 22:26
Copy link
Member

@wedamija wedamija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to use result.get since this is guaranteed?

@evanpurkhiser
Copy link
Member Author

Do we need to use result.get since this is guaranteed?

I need to bump the kafka schemas package

@evanpurkhiser evanpurkhiser enabled auto-merge (squash) August 14, 2024 22:41
@evanpurkhiser evanpurkhiser merged commit cfa8b6b into master Aug 14, 2024
48 checks passed
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/fix-uptime-always-pass-span-id-from-check-result-to-occurrence branch August 14, 2024 22:56
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants