Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(alert): Correct url #76236

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Conversation

schew2381
Copy link
Contributor

@schew2381 schew2381 commented Aug 14, 2024

URL was incorrectly changed in #76204

Will add test in future PR 🫥

@schew2381 schew2381 requested a review from ceorourke August 14, 2024 22:49
@schew2381 schew2381 self-assigned this Aug 14, 2024
@schew2381 schew2381 requested a review from a team as a code owner August 14, 2024 22:49
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Aug 14, 2024
@schew2381 schew2381 enabled auto-merge (squash) August 14, 2024 22:49
@evanpurkhiser
Copy link
Member

Can we update the test for this as well?

@schew2381 schew2381 merged commit 579c70a into master Aug 14, 2024
44 checks passed
@schew2381 schew2381 deleted the seiji/fix/correct-delete-metric-alert-url branch August 14, 2024 23:00
@schew2381
Copy link
Contributor Author

Can we update the test for this as well?

Was in a rush to go to something so I didn't have time to add it, will do later today 👍

schew2381 added a commit that referenced this pull request Aug 15, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants