Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(migrations): Generalize the migrations_added file filter #76244

Merged
merged 4 commits into from
Aug 15, 2024

Conversation

wedamija
Copy link
Member

This should match sentry/migrations as well as sentry/uptime/migrations and any other migration folders that exist throughout the sentry project

This should match `sentry/migrations` as well as `sentry/uptime/migrations` and any other migration folders that exist throughout the sentry project
@wedamija wedamija requested review from a team as code owners August 15, 2024 00:12
@github-actions github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Aug 15, 2024
Copy link
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

Copy link
Contributor

This PR has a migration; here is the generated SQL for src/sentry/migrations/0750_testjunk.py src/sentry/uptime/migrations/0008_testjunk.py ()

--
-- Add field abc to uptimesubscription
--
ALTER TABLE "uptime_uptimesubscription" ADD COLUMN "abc" integer NULL;

Copy link
Contributor

This PR has a migration; here is the generated SQL for src/sentry/migrations/0750_testjunk.py ()

--
-- Add field hkjshf to group
--
ALTER TABLE "sentry_groupedmessage" ADD COLUMN "hkjshf" timestamp with time zone NULL;

Copy link

codecov bot commented Aug 15, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
7656 1 7655 0
View the top 1 failed tests by shortest run time
Performance > TransactionSummary with events uses MEP dataset for stats query and shows fallback warning�Performance > TransactionSummary with events uses MEP dataset for stats query and shows fallback warning
Stack Traces | 0.867s run time
TestingLibraryElementError: Unable to find an element by: [data-test-id="search-metrics-fallback-warning"]

Ignored nodes: comments, script, style
...
at Object.getElementError (.../sentry/sentry/node_modules/@.../dom/dist/config.js:37:19)
at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:76:38
at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:52:17
at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:95:19
at Object.<anonymous> (.../transactionSummary/transactionOverview/index.spec.tsx:1142:42)
at runNextTicks (node:internal/process/task_queues:60:5)
at listOnTimeout (node:internal/timers:540:9)
at processTimers (node:internal/timers:514:7)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

Copy link
Member

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wedamija wedamija merged commit bf47823 into master Aug 15, 2024
37 checks passed
@wedamija wedamija deleted the danf/migrations-generalise branch August 15, 2024 16:30
@github-actions github-actions bot locked and limited conversation to collaborators Aug 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants