feat(flags): hide flags from context and add feedback button #77488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
billyvg
approved these changes
Sep 13, 2024
static/app/components/events/featureFlags/eventFeatureFlagList.tsx
Outdated
Show resolved
Hide resolved
| }) | ||
| } | ||
| > | ||
| {t('Give Feedback')} |
There was a problem hiding this comment.
Hmm I find all this text clutters and takes away focus from the other buttons, but this is what we do for breadcrumbs so ¯_(ツ)_/¯
There was a problem hiding this comment.
would it help if the button was on the far right?🤔
There was a problem hiding this comment.
Hmm I think on left is better and aligns with what we have for breadcrumb
There was a problem hiding this comment.
cool, i kept it that way!
jas-kas
approved these changes
Sep 13, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add give feedback button:
it wouldn't show up in the drawer for some reason so added it to the main component action bar:
Screen.Recording.2024-09-13.at.10.48.03.AM.mov
remove
flagsfrom the context displaycloses #77399
closes #77160