feat(discover): Update EAP dataset and entity key for discover builders #78967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilder logic to get eap dataset and entity name
github-actions
bot
added
the
Scope: Backend
edwardgou-sentry
force-pushed
the
egou/feat/update-dataset-and-entity-for-discover-eap
branch
from
1d77d7c to
6e7b059
Compare
edwardgou-sentry
force-pushed
the
egou/feat/update-dataset-and-entity-for-discover-eap
branch
from
6e7b059 to
4e188f2
Compare
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #78967 +/- ##
===========================================
+ Coverage 51.13% 78.27% +27.13%
===========================================
Files 7095 7128 +33
Lines 312363 313797 +1434
Branches 50997 51227 +230
===========================================
+ Hits 159729 245616 +85887
+ Misses 151590 61757 -89833
- Partials 1044 6424 +5380 |
Comment on lines
+1506
to
+1508
| def _get_entity_name(self) -> str: | ||
| if self.dataset in DATASET_TO_ENTITY_MAP: | ||
| return DATASET_TO_ENTITY_MAP[self.dataset].value |
There was a problem hiding this comment.
I considered adding DATASET_TO_ENTITY_MAP to snuba/dataset.py, but this feels more like a discover detail to me. The relationship between dataset to entity isn't actually 1:1 and the dataset name is not always equal to the entity name either. I think this is good enough for now, but we probably want to refactor this part of the builder in the future.
shruthilayaj
approved these changes
Oct 15, 2024
edwardgou-sentry
deleted the
egou/feat/update-dataset-and-entity-for-discover-eap
branch
cmanallen
pushed a commit
that referenced
this pull request
Oct 23, 2024
…rs (#78967) Updates EAP dataset to correctly be `events_analytics_platform` and add entity key for `eap_spans`. Also updates discover builders to stop using `_get_dataset_name` and start using `_get_entity_name` instead. This is needed because the AlertRule model obtains and stores it's `dataset` from the UI via POST api call. We need to use the proper `events_analytics_platform` dataset string so we can pass validation when creating the snuba subscription. With these changes, we will also be able to pass any discover builder validation when creating the query from the AlertRule.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates EAP dataset to correctly be
events_analytics_platformand add entity key foreap_spans.Also updates discover builders to stop using
_get_dataset_nameand start using_get_entity_nameinstead.This is needed because the AlertRule model obtains and stores it's
datasetfrom the UI via POST api call. We need to use the properevents_analytics_platformdataset string so we can pass validation when creating the snuba subscription. With these changes, we will also be able to pass any discover builder validation when creating the query from the AlertRule.