Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(issue-stream): reduce font size of events and user counts #79028

Merged
merged 2 commits into from
Oct 11, 2024
Merged

fix(issue-stream): reduce font size of events and user counts #79028

merged 2 commits into from
Oct 11, 2024

Conversation

MichaelSun48
Copy link
Member

@MichaelSun48 MichaelSun48 commented Oct 11, 2024 •
edited
Loading

closes #79017

Reduces the font size of the events and user counts from 16px to 14px. Gated by the issue-stream-table-layout flag. Also includes some minor code clean up

Before:

Screenshot 2024-10-11 at 9 51 12 AM

After:

Screenshot 2024-10-11 at 9 51 00 AM

@MichaelSun48 MichaelSun48 requested a review from a team October 11, 2024 16:51
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 11, 2024
malwilley
malwilley approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@malwilley malwilley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good normally, but when you have an event filter the text is mismatched:

CleanShot 2024-10-11 at 12 06 41@2x

(can address in another PR though)

@MichaelSun48 MichaelSun48 merged commit b4d714b into master Oct 11, 2024
43 checks passed
@MichaelSun48 MichaelSun48 deleted the msun/issueStream/reduceEventsUsersFontSize branch October 11, 2024 23:06
cmanallen pushed a commit that referenced this pull request Oct 23, 2024
@MichaelSun48 @cmanallen
fix(issue-stream): reduce font size of events and user counts (#79028)
384a0cd 
closes #79017

Reduces the font size of the events and user counts from 16px to 14px.
Gated by the `issue-stream-table-layout` flag. Also includes some minor
code clean up

Before: 

<img width="158" alt="Screenshot 2024-10-11 at 9 51 12 AM"
src="https://github.com/user-attachments/assets/218da406-c5b1-44e1-bccc-655a653e3c9a">


After:

<img width="166" alt="Screenshot 2024-10-11 at 9 51 00 AM"
src="https://github.com/user-attachments/assets/d66ce8e8-f137-4503-9b3b-d30d8727028a">
@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@malwilley malwilley malwilley approved these changes

@roggenkemper roggenkemper roggenkemper approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue Stream Table: Smaller text size for event/user counts
3 participants
@MichaelSun48 @malwilley @roggenkemper