fix(dashboard): OnDemand extraction for Transaction widgets #79055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we're splitting the datasets up, a user can create or update a widget to have DashboardWidgetTypes.TRANSACTION_LIKE as their widget type natively. Widgets like this aren't picked up by on-demand. Update the queries for on-demand widgets to also search for DashboardWidgetTypes.TRANSACTION_LIKE.
github-actions
bot
added
the
Scope: Backend
obostjancic
approved these changes
Oct 15, 2024
narsaynorath
deleted the
nar/fix/dashboard-discover-split-on-demand-widgets
branch
cmanallen
pushed a commit
that referenced
this pull request
Oct 23, 2024
Since we're splitting the datasets up, a user can create or update a widget to have DashboardWidgetTypes.TRANSACTION_LIKE as their widget type natively. Widgets like this aren't picked up by on-demand. Update the queries for on-demand widgets to also search for DashboardWidgetTypes.TRANSACTION_LIKE.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we're splitting the datasets up, a user can create or update a widget to have DashboardWidgetTypes.TRANSACTION_LIKE as their widget type natively. Widgets like this aren't picked up by on-demand.
Update the queries for on-demand widgets to also search for DashboardWidgetTypes.TRANSACTION_LIKE.