fix(dashboard): OnDemand widget creation also includes transaction type #79059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #79059 +/- ##
==========================================
- Coverage 78.29% 78.29% -0.01%
==========================================
Files 7128 7129 +1
Lines 313712 313834 +122
Branches 51200 51229 +29
==========================================
+ Hits 245629 245712 +83
- Misses 61659 61692 +33
- Partials 6424 6430 +6 |
obostjancic
approved these changes
Oct 15, 2024
narsaynorath
deleted the
nar/fix/dashboard-on-demand-widget-creation-also-checks-transactions
branch
cmanallen
pushed a commit
that referenced
this pull request
Oct 23, 2024
…pe (#79059) Ensures that the proper on-demand objects are created when widgets are updated and created. Since the discover split can create transaction types, we need to catch these types when creating the corresponding on demand objects. I've colocated the ondemand tests into one test class and parameterized the widget type so we can test the functionality against transaction widgets as well.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that the proper on-demand objects are created when widgets are updated and created.
Since the discover split can create transaction types, we need to catch these types when creating the corresponding on demand objects. I've colocated the ondemand tests into one test class and parameterized the widget type so we can test the functionality against transaction widgets as well.