fix(eap): Count takes arg #79066
Merged
fix(eap): Count takes arg #79066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike before, count() will now take an argument to count the numeric attribute with a default to count span.duration.
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #79066 +/- ##
=======================================
Coverage 78.28% 78.29%
=======================================
Files 7129 7132 +3
Lines 313857 313925 +68
Branches 51234 51253 +19
=======================================
+ Hits 245705 245774 +69
+ Misses 61724 61721 -3
- Partials 6428 6430 +2 |
|
/assign |
Abdkhan14
approved these changes
Oct 15, 2024
cmanallen
pushed a commit
that referenced
this pull request
Oct 23, 2024
Unlike before, count() will now take an argument to count the numeric attribute with a default to count `span.duration`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike before, count() will now take an argument to count the numeric attribute with a default to count
span.duration.