fix(issue-stream): Fix bug where replay divider was shown despite no replays #79068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
| projectCanLinkToReplay(organization, project); | ||
| projectCanLinkToReplay(organization, project) && | ||
| data.issueCategory && | ||
| getReplayCountForIssue(data.id, data.issueCategory); |
There was a problem hiding this comment.
can we add a > 0 here - not that it'll make a big different but at least it'll keep showReplayCount a boolean
There was a problem hiding this comment.
Good point about keeping it a boolean - that function also can return undefined, so i think just converting it to a boolean would achieve the same result without having to do a separate existence check.
roggenkemper
approved these changes
Oct 11, 2024
cmanallen
pushed a commit
that referenced
this pull request
Oct 23, 2024
…replays (#79068) before: <img width="363" alt="image" src="https://github.com/user-attachments/assets/73e0283c-0d3f-4bb0-8f4f-053bfd703ab3"> after: <img width="369" alt="image" src="https://github.com/user-attachments/assets/e74a0573-2da5-460d-a1eb-2affe9620953">
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #79020
before:
after: