ref(ingest): annotate transaction consumer with spans #79101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Occasionally we're seeing long `ingest_consumer.process_event` transactions, but the span tree doesn't reveal the bottleneck. There's a big (200ms+) gap at the start of the trace before the first child span (`ingest_consumer._store_event`). To track down what's happening during this time, add spans around each potentially time-consuming operation before that span.
github-actions
bot
added
the
Scope: Backend
jjbayer
approved these changes
Oct 15, 2024
0Calories
approved these changes
Oct 15, 2024
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #79101 +/- ##
==========================================
- Coverage 78.30% 78.29% -0.01%
==========================================
Files 7132 7132
Lines 313957 313963 +6
Branches 53079 53085 +6
==========================================
- Hits 245833 245810 -23
- Misses 61082 61102 +20
- Partials 7042 7051 +9 |
cmanallen
pushed a commit
that referenced
this pull request
Oct 23, 2024
Occasionally we're seeing long `ingest_consumer.process_event` transactions, but the span tree doesn't reveal the bottleneck. There's a big (200ms+) gap at the start of the trace before the first child span (`ingest_consumer._store_event`). To track down what's happening during this time, add spans around each potentially time-consuming operation before that span.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occasionally we're seeing long
ingest_consumer.process_eventtransactions, but the span tree doesn't reveal the bottleneck. There's a big (200ms+) gap at the start of the trace before the first child span (ingest_consumer._store_event). To track down what's happening during this time, add spans around each potentially time-consuming operation before that span.