ref(dashboards): Fixes and refactoring for edit access selector button

[harshithadurai]

#79833

Some fixes for the Edit Access dropdown button in Dashboards.

1. modified behaviour of Save Changes button in EditAccessSelector.tsx so that it's enabled only when the changed selections are not the same as the existing perms
2. pass down props so that Widget edit buttons are disabled when user does not have edit perms
3. pass down props to top level dashboard filters so that users without edit perms cannot save changes
4. pass down props to widget context menu to disable the Edit Widget button there

[codecov]

Bundle Report

Changes will decrease total bundle size by 35.84kB (-0.11%) ⬇️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
app-webpack-bundle-array-push	31.89MB	35.84kB (-0.11%) ⬇️

[codecov]

❌ 4 Tests Failed:

Tests completed	Failed	Passed	Skipped
8215	4	8211	0

View the top 3 failed tests by shortest run time

Dashboards > WidgetCard calls onEdit when Edit Widget is clicked

Stack Traces | 0.148s run time

Error: expect(jest.fn()).toHaveBeenCalledTimes(expected)

Expected number of calls: 1
Received number of calls: 0
    at Object.<anonymous> (.../dashboards/widgetCard/index.spec.tsx:351:18)

Dashboards > WidgetCard calls onDuplicate when Duplicate Widget is clicked

Stack Traces | 0.17s run time

Error: expect(jest.fn()).toHaveBeenCalledTimes(expected)

Expected number of calls: 1
Received number of calls: 0
    at Object.<anonymous> (.../dashboards/widgetCard/index.spec.tsx:295:18)

Dashboards > IssueWidgetCard calls onDuplicate when Duplicate Widget is clicked

Stack Traces | 0.283s run time

Error: expect(jest.fn()).toHaveBeenCalledTimes(expected)

Expected number of calls: 1
Received number of calls: 0
    at Object.<anonymous> (.../dashboards/widgetCard/issueWidgetCard.spec.tsx:183:18)

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

[narsaynorath]

There is also a button in the widget viewer (which opens up when you click the button next to the ... context menu) that has an edit widget button. Could we also disable that? Doesn't need to be this PR.

[narsaynorath]

Can we just pass isEqual(newSelectedValues, getSelectedOptions()) into disabled on line 207? so disabed={!isCurrentUserDashboardOwner || isEqual(newSelectedValues, getSelectedOptions())}, or you can just assign it to a variable instead of storing it in state like this

[narsaynorath]

Do we need to set the selected options when the menu is closed? The state should be handled by the onSelectOptions handler so opening and closing shouldn't have an effect on that

[narsaynorath]

Should we just pass around hasEditAccess from above? It seems like a simpler change than checking this at multiple locations.

Also, an idea for a future clean up is that I think we could put this into a context to store edit access information and create a hook called useHasEditAccess or something to avoid passing around the prop as much