chore(vsts): vsts installation step metrics #80789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #80789 +/- ##
=======================================
Coverage 78.39% 78.39%
=======================================
Files 7206 7206
Lines 319443 319449 +6
Branches 43994 43994
=======================================
+ Hits 250427 250435 +8
+ Misses 62634 62631 -3
- Partials 6382 6383 +1 |
iamrajjoshi
approved these changes
Nov 25, 2024
| user = get_user_info(access_token) | ||
|
|
||
| accounts = self.get_accounts(access_token, user["uuid"]) | ||
| logger.info( |
There was a problem hiding this comment.
do security or anyone use this log?
There was a problem hiding this comment.
i'm logging it as extra when we return the HTML template when there are no accounts. also emitting a failure there
https://github.com/getsentry/sentry/pull/80789/files#diff-ea1561c3fe6fedfc28168b76c65f65681c9efc769d6adbb617d99afaa598e867R665
GabeVillalobos
approved these changes
Nov 25, 2024
evanh
pushed a commit
that referenced
this pull request
Nov 25, 2024
andrewshie-sentry
pushed a commit
that referenced
this pull request
Dec 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds lifecycle metrics for VSTS installation:
AccountConfigViewandexchange_token(there are metrics being emitted in the superclass'sexchange_tokenbut not in the classes here that override it).