feat(dashboards): Dashboards landing page layout toggle #80790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikkikapadia
changed the title
github-actions
bot
added
the
Scope: Frontend
nikkikapadia
changed the title
narsaynorath
approved these changes
Nov 15, 2024
| const FEATURES = [ | ||
| 'global-views', | ||
| 'dashboards-basic', | ||
| 'dashboards-edit', | ||
| 'discover-query', | ||
| ]; | ||
|
|
||
| const LAYOUT_KEY = 'dashboards-overview-layout'; |
There was a problem hiding this comment.
Maybe we can just export this from the other file?
Comment on lines
79
to
81
| return dashboardsLayout === 'grid' || dashboardsLayout === 'list' | ||
| ? dashboardsLayout | ||
| : 'grid'; |
There was a problem hiding this comment.
We should put 'grid' and 'list' in constants at the top of the page to reuse them everywhere instead of dealing with strings
| onChange={setDashboardsLayout} | ||
| size="md" | ||
| value={dashboardsLayout} | ||
| aria-label="Layout Control" |
There was a problem hiding this comment.
nit, but I think we should wrap aria-labels with t() because they're user-facing and should also match the user's language
There was a problem hiding this comment.
oooo yes good catch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a toggle to change the dashboards layout from grid to table. This is under feature flag and available to only me right now (since there is no functionality to the toggle as of yet). Actual table layout will be implemented in further PRs.
ALSO I am aware that the icon for grid right now is the dashboards icon, Vasudha is working on getting the proper icon for the grid.