-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(functions): Use flamegraph as data source for slowest functions #80791
feat(functions): Use flamegraph as data source for slowest functions #80791
Conversation
This switches the slowest functions table within transaction summary to use flamegraphs as a data source instead of the functions table. This is because with continuous profiling, the functions table does not have any transaction information for continuous profiles. So to be compatible with both profiling modes, we need to switch to using flamegraphs.
…use-flamegraph-as-data-source-for-slowest-functions
❌ 3 Tests Failed:
View the top 3 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
@Zylphrex just a clarification: this is to use the live-aggregated metrics attached to the flamegraph, correct? |
Yes, that is correct. |
This switches the slowest functions table within transaction summary to use flamegraphs as a data source instead of the functions table. This is because with continuous profiling, the functions table does not have any transaction information for continuous profiles. So to be compatible with both profiling modes, we need to switch to using flamegraphs.