Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(dashboards): added grid icon #80806

Merged
merged 1 commit into from
Nov 15, 2024
Merged

feature(dashboards): added grid icon #80806

merged 1 commit into from
Nov 15, 2024

Conversation

doralchan
Copy link
Contributor

@doralchan doralchan commented Nov 15, 2024

In the component library:

Screenshot 2024-11-14 at 8 27 20 PM

@doralchan doralchan requested a review from a team as a code owner November 15, 2024 04:28
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 15, 2024
@doralchan doralchan requested a review from gggritso November 15, 2024 04:29
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
static/app/icons/iconGrid.tsx 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #80806      +/-   ##
==========================================
+ Coverage   74.97%   78.40%   +3.43%     
==========================================
  Files        7207     7208       +1     
  Lines      319509   319512       +3     
  Branches    44001    44001              
==========================================
+ Hits       239546   250509   +10963     
+ Misses      73442    62623   -10819     
+ Partials     6521     6380     -141     

Copy link
Member

@gggritso gggritso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@doralchan doralchan merged commit 985a324 into master Nov 15, 2024
47 checks passed
@doralchan doralchan deleted the feat/add-grid-icon branch November 15, 2024 16:08
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants