fix(issues): Show 50+ Replays whenever the count is maxed out like that #80809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
ryan953
commented
Nov 15, 2024
Comment on lines
-68
to
-71
| {t( | ||
| 'There are %s for this issue.', | ||
| tn('%s replay', '%s replays', replayCount ?? 0) | ||
| )} |
There was a problem hiding this comment.
This was never the right way to translate the sentence. Using tn() inside a t()... or any other combination of nesting like that... is going to make it hard for translators and lead to bad translations.
JoshFerge
approved these changes
Nov 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The replayCount is only accurate for a small number of replays. So the backend will max-out when it finds there are 51 replays in the list. The frontend is therefore responsible for rendering
"50+"when it sees a count of51.This PR updates a few spots related to Issue Details so that we render
50+instead of51.