Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dynamic-sampling): set dynamic sampling project span count mql query limit #80812

Merged
merged 1 commit into from
Nov 15, 2024
Merged

fix(dynamic-sampling): set dynamic sampling project span count mql query limit #80812

merged 1 commit into from
Nov 15, 2024

Conversation

shellmayr
Copy link
Member

@shellmayr shellmayr commented Nov 15, 2024 •
edited
Loading

  • The query layer seems to have a dynamic limit if the limit is not set in the MQL Query
  • This PR fixes that the number of returned elements is dynamically changed depending on 24h vs 30d

Contributes to https://github.com/getsentry/projects/issues/353

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 15, 2024
@shellmayr shellmayr requested review from ArthurKnaus and a team November 15, 2024 08:24
@shellmayr shellmayr marked this pull request as ready for review November 15, 2024 08:33
@shellmayr shellmayr merged commit ec07d75 into master Nov 15, 2024
51 checks passed
@shellmayr shellmayr deleted the shellmayr/fix/set-dynamic-sampling-project-span-counts-limit branch November 15, 2024 09:18
@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vgrozdanic vgrozdanic vgrozdanic approved these changes

@ArthurKnaus ArthurKnaus Awaiting requested review from ArthurKnaus

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shellmayr @vgrozdanic