feat(dynamic-sampling): Show stored span per sub-project #80816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
vgrozdanic
reviewed
Nov 15, 2024
| ) { | ||
| let subSpansContent: React.ReactNode = ''; | ||
| if (subProjects.length > 0) { | ||
| const subProjectSum = subProjects.reduce( |
There was a problem hiding this comment.
nit: do we want to cache this so that it is not re-calculated on re-renders?
There was a problem hiding this comment.
not really worth it in this case, as the whole list item is already heavily memoized and rarely renders.
vgrozdanic
approved these changes
Nov 15, 2024
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #80816 +/- ##
==========================================
+ Coverage 74.96% 78.39% +3.42%
==========================================
Files 7207 7207
Lines 319509 319514 +5
Branches 44001 44003 +2
==========================================
+ Hits 239529 250487 +10958
+ Misses 73455 62643 -10812
+ Partials 6525 6384 -141 |
ArthurKnaus
deleted the
aknaus/feat/dynamic-sampling/show-stored-span-per-sub-project
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display the stored span count for each sub project.
Screen.Recording.2024-11-15.at.09.44.19.mov
Part of https://github.com/getsentry/projects/issues/390