chore(integrations): SourceCodeSearchEndpoint metrics #80956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #80956 +/- ##
==========================================
+ Coverage 80.32% 80.33% +0.01%
==========================================
Files 7215 7215
Lines 319443 319409 -34
Branches 20773 20773
==========================================
+ Hits 256583 256604 +21
+ Misses 62466 62411 -55
Partials 394 394 |
iamrajjoshi
reviewed
Nov 21, 2024
Comment on lines
+64
to
+65
| assert halt1.args[0] == EventLifecycleOutcome.SUCCESS | ||
| assert halt2.args[0] == EventLifecycleOutcome.SUCCESS |
There was a problem hiding this comment.
Super minor naming Nit: these are success metrics, not halts
mifu67
force-pushed
the
mifu67/scse-observability-metrics
branch
from
465ca5c to
d0b79e0
Compare
cathteng
reviewed
Nov 25, 2024
Comment on lines
+55
to
+57
| logger.info( | ||
| "bitbucket.issue-search-no-issue-tracker", | ||
| extra={"installation_id": installation.model.id, "repo": repo}, |
There was a problem hiding this comment.
will there be a followup task to remove these extra logs?
| response = installation.search_issues(query=full_query, repo=repo) | ||
| except ApiError as e: | ||
| if "no issue tracker" in str(e): | ||
| lifecycle.record_halt(str(SourceCodeSearchEndpointHaltReason.NO_ISSUE_TRACKER)) |
There was a problem hiding this comment.
since SourceCodeSearchEndpointHaltReason is a StrEnum, you shouldn't need to cast it into a string again
| except ApiError as err: | ||
| if err.code == 403: | ||
| lifecycle.record_halt(str(SourceCodeSearchEndpointHaltReason.RATE_LIMITED)) | ||
| return Response({"detail": "Rate limit exceeded"}, status=429) |
There was a problem hiding this comment.
lol not sure why we're returning a 429 on a 403 🤔
| try: | ||
| response = installation.search_projects(query) | ||
| except ApiError as e: | ||
| lifecyle.record_failure(e) |
There was a problem hiding this comment.
if a 400 is a user-related error response, should this be halt instead?
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Dec 2, 2024
Add metrics to `handle_search_issues`, `handle_search_repositories`, and `get`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add metrics to
handle_search_issues,handle_search_repositories, andget.