feat(toolbar): Make the login-success page have styles that blend with the login flow #81230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
billyvg
approved these changes
Nov 25, 2024
Comment on lines
-53
to
-56
| {% comment %} | ||
| No need to close `body`. If we do then middleware will inject some extra markup | ||
| we don't need. Browsers can figure out when it missing and deal with it. | ||
| {% endcomment %} |
There was a problem hiding this comment.
Does the middleware get injected again now?
There was a problem hiding this comment.
ya, there's loads of default stuff that's brought in now, perf timing... i wasted a moment last week fidgeting with the footer i guess.
I think though that this template is done-done at this point!
andrewshie-sentry
pushed a commit
that referenced
this pull request
Dec 2, 2024
…h the login flow (#81230) | With timeout (`?delay=3000`) | Debug Mode (`?delay=0`) | | --- | --- | | <img width="802" alt="SCR-20241125-pabk" src="https://github.com/user-attachments/assets/8af9b71b-229e-46e2-b542-6215a37e7a84"> | <img width="802" alt="SCR-20241125-nxmx" src="https://github.com/user-attachments/assets/ddc71216-563c-474e-b5c8-4016224e0649">
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
?delay=3000)?delay=0)