ref(insights): remove insights-domain-view flag part 1 #81241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #81241 +/- ##
=======================================
Coverage 80.34% 80.34%
=======================================
Files 7219 7220 +1
Lines 319544 319559 +15
Branches 20779 20779
=======================================
+ Hits 256738 256758 +20
+ Misses 62412 62406 -6
- Partials 394 395 +1 |
gggritso
approved these changes
Nov 25, 2024
DominikB2014
deleted the
DominikB2014/remove-insights-domain-view-flag
branch
DominikB2014
added a commit
that referenced
this pull request
Nov 26, 2024
This is part 2 of removing `insights-domain-view` flag (see #81241 for details) In this PR: 1. remove the usage of the flag in the sidebar 2. remove old routes and links to non domain view modules 3. some misc changes related to the the domain view flag being in the sidebar/routes
andrewshie-sentry
pushed a commit
that referenced
this pull request
Dec 2, 2024
Now that domain views have been in GA for about a week, we can remove the flag that controls it. This is part 1 of the flag removal, i'm splitting this up to make it easier to review. In this part we remove the flag in all the associated utils and the domain view landing pages. In the domain view landing pages, we also replace the flag from `insights-domain-view` to `performance-view`, as performance view is a pre-requisite of the insights views.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Dec 2, 2024
This is part 2 of removing `insights-domain-view` flag (see #81241 for details) In this PR: 1. remove the usage of the flag in the sidebar 2. remove old routes and links to non domain view modules 3. some misc changes related to the the domain view flag being in the sidebar/routes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that domain views have been in GA for about a week, we can remove the flag that controls it.
This is part 1 of the flag removal, i'm splitting this up to make it easier to review.
In this part we remove the flag in all the associated utils and the domain view landing pages.
In the domain view landing pages, we also replace the flag from
insights-domain-viewtoperformance-view, as performance view is a pre-requisite of the insights views.