fix(explore): Preserve sort when adding group by #81258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use the first available option to sort when there's no sort specified. In aggregate mode, when adding a group by, the first option changes from the aggregate function to the group by field thus implicitly changing the sort. This ensures that the aggregate functions are higher in the list so the default sort doesnt change when the group by changes.
github-actions
bot
added
the
Scope: Frontend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #81258 +/- ##
==========================================
- Coverage 80.34% 80.34% -0.01%
==========================================
Files 7219 7220 +1
Lines 319544 319570 +26
Branches 20779 20783 +4
==========================================
+ Hits 256736 256752 +16
- Misses 62417 62427 +10
Partials 391 391 |
wmak
approved these changes
Nov 25, 2024
andrewshie-sentry
pushed a commit
that referenced
this pull request
Dec 2, 2024
We use the first available option to sort when there's no sort specified. In aggregate mode, when adding a group by, the first option changes from the aggregate function to the group by field thus implicitly changing the sort. This ensures that the aggregate functions are higher in the list so the default sort doesnt change when the group by changes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use the first available option to sort when there's no sort specified. In aggregate mode, when adding a group by, the first option changes from the aggregate function to the group by field thus implicitly changing the sort. This ensures that the aggregate functions are higher in the list so the default sort doesnt change when the group by changes.