Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better logging for backpressure #81648

Merged
merged 15 commits into from
Dec 10, 2024
Merged

Better logging for backpressure #81648

merged 15 commits into from
Dec 10, 2024

Conversation

kneeyo1
Copy link
Contributor

@kneeyo1 kneeyo1 commented Dec 4, 2024

This just adds host/port of the service to the logs.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Dec 4, 2024
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 5 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/processing/backpressure/monitor.py 40.00% 3 Missing ⚠️
src/sentry/processing/backpressure/memory.py 90.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #81648      +/-   ##
==========================================
+ Coverage   80.33%   80.51%   +0.17%     
==========================================
  Files        7265     7256       -9     
  Lines      321030   322338    +1308     
  Branches    20900    20777     -123     
==========================================
+ Hits       257902   259515    +1613     
+ Misses      62733    62428     -305     
  Partials      395      395              

@kneeyo1 kneeyo1 changed the title WIP, need to add the host/port combo to the error WIP, better logging Dec 4, 2024
@kneeyo1 kneeyo1 changed the title WIP, better logging Better logging Dec 4, 2024
@kneeyo1 kneeyo1 changed the title Better logging Better logging for backpressure Dec 4, 2024
@kneeyo1 kneeyo1 marked this pull request as ready for review December 9, 2024 23:47
@kneeyo1 kneeyo1 requested a review from mwarkentin December 9, 2024 23:48
@kneeyo1 kneeyo1 merged commit 040076d into master Dec 10, 2024
49 checks passed
@kneeyo1 kneeyo1 deleted the improve-backpressure-logging branch December 10, 2024 21:21
@github-actions github-actions bot locked and limited conversation to collaborators Dec 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants