-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(widget-builder): Batch URL param changes #81923
feat(widget-builder): Batch URL param changes #81923
Conversation
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
@@ -2185,6 +2193,12 @@ describe('Dashboards > Detail', function () { | |||
id: '1', | |||
title: 'Custom Errors', | |||
}); | |||
jest.mocked(useWidgetBuilderState).mockReturnValue({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mocked a bunch of these explicitly to avoid triggering the debounced stuff in the new state update provider. The updates here aren't actually that interesting, just as long as we know that adding the widget works with the correct state.
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Batch together URL param updates. This allows us to modify different values in the widget builder state serially but push to the URL only once. e.g. clearing sort by when switching to a big number widget.