fix(merged): Always show a link for latests event of a merged group #81947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
scttcper
reviewed
Dec 10, 2024
Comment on lines
87
to
89
| () => { | ||
| GroupingStore.listen(data => onGroupChange(data), undefined); | ||
| }, |
There was a problem hiding this comment.
you want to remove the listener on unmount by calling the returned function from listen
scttcper
approved these changes
Dec 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51294 but only the UX issues.
It seems like the rendering is only a byproduct of a different issue. Either way, if we can generate a link, we'll do so here, though the subtitle/title showing up blank is better described by #57383
Also converts the component to an FC, so the change looks bigger than it is.