Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat(discord): add button to redirect for user linking #82104

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

iamrajjoshi
Copy link
Member

Slack had a button that would redirect you to slack workspace after linking identity.

Did the same for Discord

Closes: #58043

Screen.Recording.2024-12-13.at.1.15.47.PM.mov

@iamrajjoshi iamrajjoshi self-assigned this Dec 13, 2024
@iamrajjoshi iamrajjoshi requested review from a team as code owners December 13, 2024 21:19
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Dec 13, 2024
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Dec 13, 2024
Copy link
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...sentry/integrations/discord/views/link_identity.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #82104       +/-   ##
===========================================
+ Coverage   59.03%   80.37%   +21.33%     
===========================================
  Files        7264     7275       +11     
  Lines      320887   321411      +524     
  Branches    20962    20962               
===========================================
+ Hits       189444   258328    +68884     
+ Misses     131032    62672    -68360     
  Partials      411      411               

@iamrajjoshi iamrajjoshi merged commit 2303409 into master Dec 13, 2024
53 checks passed
@iamrajjoshi iamrajjoshi deleted the raj/discord-redirect branch December 13, 2024 22:28
evanh pushed a commit that referenced this pull request Dec 17, 2024
Slack had a button that would redirect you to slack workspace after
linking identity.

Did the same for Discord

Closes: #58043


https://github.com/user-attachments/assets/6792b8f1-b5e2-4a76-993d-69a83443ad02
@github-actions github-actions bot locked and limited conversation to collaborators Dec 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redirect to Discord after successful /link
2 participants