fix(toolbar): Include credentials with fetch requests #82108
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our fetch requests are cross-domain by design, we're making requests from a customer domain like
acme.sentry.io
into a an region likeus.sentry.io
. Therefore we need to include credentials. This is also how the website is configured:sentry/static/app/api.tsx
Line 338 in aa22f5d
More docs: https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API/Using_Fetch#including_credentials
Previously we had
same-origin
which worked because we weren't using the regionUrl. We were instead sending api requests to the customer domain atacme.sentry.io
. This meant that api requests were slower than using the regionUrl, but and also we were unable to make requests for api endpoints that don't include an/:organization/
segment.So using the regionUrl is an improvement, and this PR updates the credentials field to match.
Another thing to consider is that before we were using
window.location.origin
to make requests. That has since been replaced bysentry/src/sentry/templates/sentry/toolbar/iframe.html
Line 31 in aa22f5d
Related to #81942