ref(issue-views): Overhaul issue views state and logic to a new context #82429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
MichaelSun48
force-pushed
the
msun/issueViews/moveLogicToContext
branch
from
0ca20a8 to
71c94e0
Compare
MichaelSun48
commented
Dec 19, 2024
| import {NewTabContext, type NewView} from 'sentry/views/issueList/utils/newTabContext'; | ||
|
|
||
| export interface Tab { |
There was a problem hiding this comment.
Renamed to IssueView and moved to IssueViews.tsx
malwilley
reviewed
Dec 19, 2024
| ); | ||
| } | ||
|
|
||
| export function IssueViews<T extends string | number>({ |
There was a problem hiding this comment.
Can we extract this to a new file? We don't usually include components in util files
There was a problem hiding this comment.
Maybe rename this to issueViewsContext to be more descriptive? Might also be better to put everything together in an issueViews folder or something so that this isn't floating off in the utils folder for the whole issue list
There was a problem hiding this comment.
Dropped this in /groupsearchviewtabs/ for now, but I do want to save bigger renamings and restructures for a separate PR since there are a bunch of other places where it could be improved.
| } | ||
|
|
||
| export const IssueViewsContext = createContext<IssueViewsContextType>({ | ||
| rootProps: {orientation: 'horizontal'}, |
There was a problem hiding this comment.
Is this necessary to be in the context?
There was a problem hiding this comment.
This is one of react-aria's tab context variables that I included since this context is essentially just a wrapper on that one. I copied the behavior from our base tabs component here.
Bundle ReportChanges will increase total bundle size by 39.07kB (0.12%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
malwilley
reviewed
Dec 20, 2024
MichaelSun48
added a commit
that referenced
this pull request
Dec 20, 2024
I deleted some of the analytics calls in [this refactoring change](#82429) and forgot to add them back. This PR adds them back. I found what the old analytics keys were [here](https://github.com/getsentry/sentry/blob/7cb3a89c7a0737ea5c53ab0a1e85b03c7d8dd4ee/static/app/views/issueList/groupSearchViewTabs/draggableTabBar.tsx)
MichaelSun48
added a commit
that referenced
this pull request
Dec 27, 2024
) This PR refactors the issue views family of components by moving lots of the navigation logic into the IssueViews context created in [this PR](#82429). Many of the tab actions that were folded into the IssueViews context require changes to the query parameters, which is why it makes sense to combine these two actions in the reducer function. For example: * Duplicating a tab requires the newly created tab to be selected (change viewId parameter) * Discarding a tab's changes requires the query/sort to be reset to the original query/sort (change query/sort param
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jan 2, 2025
…xt (#82429) This PR makes a major code refactor to the Issue Views family of components. No functionality should be broken or otherwise altered. The purpose of this refactor was to move lots of reused code and duplicated state into one unified context, `IssueViews.tsx`. This allows the displayed components to be much much cleaner and easier to understand while making it easier to add new functionality in the future. The two primary things it does are: 1. **Creates a new context, `IssueViews`, that extends the old `Tabs` context. This new context now contains the views and temporary tabs state** 2. **Delegates almost all tab alteration logic to a `useReducer` within the `IssueViews` context**
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jan 2, 2025
I deleted some of the analytics calls in [this refactoring change](#82429) and forgot to add them back. This PR adds them back. I found what the old analytics keys were [here](https://github.com/getsentry/sentry/blob/7cb3a89c7a0737ea5c53ab0a1e85b03c7d8dd4ee/static/app/views/issueList/groupSearchViewTabs/draggableTabBar.tsx)
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jan 2, 2025
) This PR refactors the issue views family of components by moving lots of the navigation logic into the IssueViews context created in [this PR](#82429). Many of the tab actions that were folded into the IssueViews context require changes to the query parameters, which is why it makes sense to combine these two actions in the reducer function. For example: * Duplicating a tab requires the newly created tab to be selected (change viewId parameter) * Discarding a tab's changes requires the query/sort to be reset to the original query/sort (change query/sort param
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a major code refactor to the Issue Views family of components. No functionality should be broken or otherwise altered.
The purpose of this refactor was to move lots of reused code and duplicated state into one unified context,
IssueViews.tsx. This allows the displayed components to be much much cleaner and easier to understand while making it easier to add new functionality in the future. The two primary things it does are:IssueViews, that extends the oldTabscontext. This new context now contains the views and temporary tabs stateuseReducerwithin theIssueViewscontext