Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(flags): separate permission class #82463

Merged
merged 2 commits into from
Dec 20, 2024
Merged

fix(flags): separate permission class #82463

merged 2 commits into from
Dec 20, 2024

Conversation

oioki
Copy link
Member

@oioki oioki commented Dec 20, 2024

No description provided.

@oioki oioki requested a review from a team as a code owner December 20, 2024 16:36
@oioki oioki requested a review from cmanallen December 20, 2024 16:36
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Dec 20, 2024
@oioki oioki merged commit e8371a7 into master Dec 20, 2024
47 checks passed
@oioki oioki deleted the fix/flags-secrets-permission-class branch December 20, 2024 18:12
@codecov Codecov
Copy link

codecov bot commented Dec 20, 2024 •
edited
Loading

❌ 3 Tests Failed:

Tests completed Failed Passed Skipped
23369 3 23366 213
View the top 3 failed tests by shortest run time 
tests.symbolicator.test_minidump_full.SymbolicatorMinidumpIntegrationTest::test_missing_dsym
Stack Traces | 0.343s run time 
No failure message available
tests.symbolicator.test_minidump_full.SymbolicatorMinidumpIntegrationTest::test_reprocessing
Stack Traces | 1.4s run time 
No failure message available
tests.symbolicator.test_minidump_full.SymbolicatorMinidumpIntegrationTest::test_minidump_threadnames
Stack Traces | 13.8s run time 
No failure message available

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

andrewshie-sentry pushed a commit that referenced this pull request Jan 2, 2025
@oioki @andrewshie-sentry
fix(flags): separate permission class (#82463)
a501234
@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cmanallen cmanallen cmanallen approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oioki @cmanallen