Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): Add react_config context on auth pages take 2 #82480

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

BYK
Copy link
Member

@BYK BYK commented Dec 20, 2024

Follow up to #82396 and should fix getsentry/self-hosted#3473

@BYK BYK requested review from a team as code owners December 20, 2024 18:01
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Dec 20, 2024
@BYK BYK requested a review from billyvg December 20, 2024 18:02
Copy link

codecov bot commented Dec 20, 2024

❌ 3 Tests Failed:

Tests completed Failed Passed Skipped
23375 3 23372 214
View the top 3 failed tests by shortest run time
tests.sentry.web.frontend.test_react_page.ReactPageViewTest::test_customer_domain_non_member_org_staff
Stack Traces | 2.83s run time
#x1B[1m#x1B[.../web/frontend/test_react_page.py#x1B[0m:322: in test_customer_domain_non_member_org_staff
    self._run_customer_domain_elevated_privileges(is_superuser=False, is_staff=True)
#x1B[1m#x1B[.../web/frontend/test_react_page.py#x1B[0m:305: in _run_customer_domain_elevated_privileges
    assert self.client.session["activeorg"] == other_org.slug
#x1B[1m#x1B[31m.venv/lib/python3.12.../sessions/backends/base.py#x1B[0m:55: in __getitem__
    return self._session[key]
#x1B[1m#x1B[31mE   KeyError: 'activeorg'#x1B[0m
tests.sentry.web.test_api.ClientConfigViewTest__InMonolithMode::test_staff
Stack Traces | 3.01s run time
#x1B[1m#x1B[.../sentry/web/test_api.py#x1B[0m:342: in test_staff
    self._run_test_with_privileges(is_superuser=False, is_staff=True)
#x1B[1m#x1B[.../sentry/web/test_api.py#x1B[0m:309: in _run_test_with_privileges
    assert self.client.session["activeorg"] == other_org.slug
#x1B[1m#x1B[31m.venv/lib/python3.12.../sessions/backends/base.py#x1B[0m:55: in __getitem__
    return self._session[key]
#x1B[1m#x1B[31mE   KeyError: 'activeorg'#x1B[0m
tests.sentry.web.test_api.ClientConfigViewTest::test_staff
Stack Traces | 4.1s run time
#x1B[1m#x1B[.../sentry/web/test_api.py#x1B[0m:342: in test_staff
    self._run_test_with_privileges(is_superuser=False, is_staff=True)
#x1B[1m#x1B[.../sentry/web/test_api.py#x1B[0m:309: in _run_test_with_privileges
    assert self.client.session["activeorg"] == other_org.slug
#x1B[1m#x1B[31m.venv/lib/python3.12.../sessions/backends/base.py#x1B[0m:55: in __getitem__
    return self._session[key]
#x1B[1m#x1B[31mE   KeyError: 'activeorg'#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@BYK BYK merged commit fd99887 into master Dec 20, 2024
49 checks passed
@BYK BYK deleted the byk/fix/auth-sso-react-context branch December 20, 2024 19:55
BYK added a commit that referenced this pull request Dec 23, 2024
Follow up to #82480 and #82396. Should fix the final complaints, minor issues mentioned in getsentry/self-hosted#3473
BYK added a commit that referenced this pull request Dec 23, 2024
Follow up to #82480 and #82396. Should fix the final complaints, minor
issues mentioned in getsentry/self-hosted#3473
andrewshie-sentry pushed a commit that referenced this pull request Jan 2, 2025
Follow up to #82480 and #82396. Should fix the final complaints, minor
issues mentioned in getsentry/self-hosted#3473
@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Login Redirect Problem
3 participants