ref(profiling): Merge profile provider for both modes #83338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This merges the 2 providers for transaction and continuous type profiles into 1 so that we can pass either type of profile to it anywhere instead of having 2 different providers.
github-actions
bot
added
the
Scope: Frontend
Zylphrex
commented
Jan 13, 2025
| }, | ||
| [setProfiles] | ||
| ); | ||
| const onImport = useCallback(() => {}, []); |
There was a problem hiding this comment.
This is actually broken, so l disabled it for now and we'll see if we can add it back later or remove it entirely.
There was a problem hiding this comment.
Safe to remove imo, I can take care of it
JonasBa
reviewed
Jan 14, 2025
| }, | ||
| includeAllArgs: true, | ||
| }) | ||
| .then(([data]) => data.chunk); |
There was a problem hiding this comment.
I guess. we dont really need includeAllArgs if we just access data afterwards. Is this some old copy paste relic?
There was a problem hiding this comment.
yes, gonna leave it in for now
JonasBa
approved these changes
Jan 14, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jan 22, 2025
This merges the 2 providers for transaction and continuous type profiles into 1 so that we can pass either type of profile to it anywhere instead of having 2 different providers.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges the 2 providers for transaction and continuous type profiles into 1 so that we can pass either type of profile to it anywhere instead of having 2 different providers.