Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(react19): Remove various styled defaultProps #83409

Merged
merged 2 commits into from
Jan 14, 2025
Merged

ref(react19): Remove various styled defaultProps #83409

merged 2 commits into from
Jan 14, 2025

Conversation

scttcper
Copy link
Member

Part of https://github.com/getsentry/frontend-tsc/issues/68

defaultProps are removed in react 19 for functional components, we can usually pass props in another way or apply them in the one place they're used

@scttcper
ref(react19): Remove various styled defaultProps
8b5b941 
Part of getsentry/frontend-tsc#68

defaultProps are removed in react 19, we can usually pass props in another way or apply them in the one place they're used
@scttcper scttcper requested a review from a team January 14, 2025 18:01
@scttcper scttcper requested review from a team as code owners January 14, 2025 18:01
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jan 14, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 14, 2025 •
edited
Loading

❌ 5 Tests Failed:

Tests completed Failed Passed Skipped
8522 5 8517 2
View the top 3 failed tests by shortest run time 
RadioGroupPanel calls onChange when clicked
Stack Traces | 0.137s run time 
Error: Expected test not to call console.error().

If the error is expected, test for it explicitly by mocking it out using jest.spyOn(console, 'error').mockImplementation() and test that the warning occurs.

Warning: React does not recognize the `radioSize` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `radiosize` instead. If you accidentally passed it from a parent component, remove it from the DOM element.
    at input
    at .../sentry/sentry/node_modules/@.../react/dist/emotion-element-48d2c2e4.cjs.dev.js:62:23
    at label
    at .../sentry/sentry/node_modules/@.../react/dist/emotion-element-48d2c2e4.cjs.dev.js:62:23
    at div
    at .../sentry/sentry/node_modules/@.../react/dist/emotion-element-48d2c2e4.cjs.dev.js:62:23
    at div
    at .../sentry/sentry/node_modules/@.../react/dist/emotion-element-48d2c2e4.cjs.dev.js:62:23
    at RadioPanelGroup (.../alerts/wizard/radioPanelGroup.tsx:14:3)
    at GlobalDrawer (.../components/globalDrawer/index.tsx:25:3)
    at $4068a0fae83b6d84$export$323e4fc2fa4753fb (.../sentry/sentry/node_modules/@.../utils/dist/packages/@.../utils/src/openLink.tsx:41:8)
    at ProvideAriaRouter (.../app/utils/provideAriaRouter.tsx:17:3)
    at routeContext (.../sentry/sentry/node_modules/react-router/lib/hooks.tsx:658:26)
    at RenderErrorBoundary (.../sentry/sentry/node_modules/react-router/lib/hooks.tsx:584:5)
    at routes (.../sentry/sentry/node_modules/react-router-dom/index.tsx:760:3)
    at basenameProp (.../sentry/sentry/node_modules/react-router/lib/components.tsx:413:13)
    at fallbackElement (.../sentry/sentry/node_modules/react-router-dom/index.tsx:487:3)
    at QueryClientProvider (.../sentry/sentry/node_modules/@.../react-query/src/QueryClientProvider.tsx:30:3)
    at ThemeProvider (.../sentry/sentry/node_modules/@.../react/dist/emotion-element-48d2c2e4.cjs.dev.js:125:32)
    at .../js/sentry-test/reactTestingLibrary.tsx:75:5
    at console.captureMessage [as error] (.../sentry/sentry/node_modules/jest-fail-on-console/index.js:83:25)
    at printWarning (.../sentry/sentry/node_modules/react-dom/cjs/react-dom.development.js:86:30)
    at error (.../sentry/sentry/node_modules/react-dom/cjs/react-dom.development.js:60:7)
    at validateProperty$1 (.../sentry/sentry/node_modules/react-dom/cjs/react-dom.development.js:3757:7)
    at warnUnknownProperties (.../sentry/sentry/node_modules/react-dom/cjs/react-dom.development.js:3803:21)
    at validateProperties$2 (.../sentry/sentry/node_modules/react-dom/cjs/react-dom.development.js:3827:3)
    at validatePropertiesInDevelopment (.../sentry/sentry/node_modules/react-dom/cjs/react-dom.development.js:9541:5)
    at setInitialProperties (.../sentry/sentry/node_modules/react-dom/cjs/react-dom.development.js:9830:5)
    at finalizeInitialChildren (.../sentry/sentry/node_modules/react-dom/cjs/react-dom.development.js:10950:3)
    at completeWork (.../sentry/sentry/node_modules/react-dom/cjs/react-dom.development.js:22193:17)
    at completeUnitOfWork (.../sentry/sentry/node_modules/react-dom/cjs/react-dom.development.js:26593:16)
    at performUnitOfWork (.../sentry/sentry/node_modules/react-dom/cjs/react-dom.development.js:26568:5)
    at workLoopSync (.../sentry/sentry/node_modules/react-dom/cjs/react-dom.development.js:26466:5)
    at renderRootSync (.../sentry/sentry/node_modules/react-dom/cjs/react-dom.development.js:26434:7)
    at performConcurrentWorkOnRoot (.../sentry/sentry/node_modules/react-dom/cjs/react-dom.development.js:25738:74)
    at flushActQueue (.../sentry/sentry/node_modules/react/cjs/react.development.js:2667:24)
    at act (.../sentry/sentry/node_modules/react/cjs/react.development.js:2582:11)
    at .../sentry/sentry/node_modules/@.../react/dist/act-compat.js:47:25
    at renderRoot (.../sentry/sentry/node_modules/@.../react/dist/pure.js:180:26)
    at Object.render (.../sentry/sentry/node_modules/@.../react/dist/pure.js:271:10)
    at render (.../js/sentry-test/reactTestingLibrary.tsx:193:14)
    at Object.<anonymous> (.../alerts/wizard/radioPanelGroup.spec.tsx:10:37)
    at Promise.then.completed (.../sentry/sentry/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/sentry/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at _runTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:121:9)
    at run (.../sentry/sentry/node_modules/jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:444:34)
    at Object.worker (.../sentry/sentry/node_modules/jest-runner/build/testWorker.js:106:12)
    at flushUnexpectedConsoleCalls (.../sentry/sentry/node_modules/jest-fail-on-console/index.js:48:13)
    at Object.<anonymous> (.../sentry/sentry/node_modules/jest-fail-on-console/index.js:139:7)
    at Promise.then.completed (.../sentry/sentry/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/sentry/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusHook (.../sentry/sentry/node_modules/jest-circus/build/run.js:281:40)
    at _runTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:254:5)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:121:9)
    at run (.../sentry/sentry/node_modules/jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:444:34)
    at Object.worker (.../sentry/sentry/node_modules/jest-runner/build/testWorker.js:106:12)
Onboarding renders framework selection modal if vanilla js is selected
Stack Traces | 0.215s run time 
Error: Expected test not to call console.error().

If the error is expected, test for it explicitly by mocking it out using jest.spyOn(console, 'error').mockImplementation() and test that the warning occurs.

Warning: React does not recognize the `radioSize` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `radiosize` instead. If you accidentally passed it from a parent component, remove it from the DOM element.
    at input
    at .../sentry/sentry/node_modules/@.../react/dist/emotion-element-48d2c2e4.cjs.dev.js:62:23
    at label
    at .../sentry/sentry/node_modules/@.../react/dist/emotion-element-48d2c2e4.cjs.dev.js:62:23
    at li
    at .../components/list/listItem.tsx:14:3
    at .../sentry/sentry/node_modules/@.../react/dist/emotion-element-48d2c2e4.cjs.dev.js:62:23
    at ul
    at Object.<anonymous>.process.env.NODE_ENV.target (.../components/list/index.tsx:14:3)
    at .../sentry/sentry/node_modules/@.../react/dist/emotion-element-48d2c2e4.cjs.dev.js:62:23
    at div
    at .../sentry/sentry/node_modules/@.../react/dist/emotion-element-48d2c2e4.cjs.dev.js:62:23
    at ThemeProvider (.../sentry/sentry/node_modules/@.../react/dist/emotion-element-48d2c2e4.cjs.dev.js:125:32)
    at PanelProvider (.../app/utils/panelProvider.tsx:29:3)
    at div
    at .../components/panels/panel.tsx:15:3
    at .../sentry/sentry/node_modules/@.../react/dist/emotion-element-48d2c2e4.cjs.dev.js:62:23
    at section
    at .../sentry/sentry/node_modules/@.../react/dist/emotion-element-48d2c2e4.cjs.dev.js:62:23
    at FrameworkSuggestionModal (.../components/onboarding/frameworkSuggestionModal.tsx:56:3)
    at div
    at .../sentry/sentry/node_modules/@.../react/dist/emotion-element-48d2c2e4.cjs.dev.js:62:23
    at div
    at MotionComponent (.../sentry/sentry/node_modules/framer-motion/dist/cjs/index.js:498:22)
    at .../sentry/sentry/node_modules/@.../react/dist/emotion-element-48d2c2e4.cjs.dev.js:62:23
    at .../sentry/sentry/node_modules/@.../react/dist/emotion-element-48d2c2e4.cjs.dev.js:62:23
    at PresenceChild (.../sentry/sentry/node_modules/framer-motion/dist/cjs/index.js:10900:26)
    at AnimatePresence (.../sentry/sentry/node_modules/framer-motion/dist/cjs/index.js:11022:28)
    at div
    at .../sentry/sentry/node_modules/@.../react/dist/emotion-element-48d2c2e4.cjs.dev.js:62:23
    at GlobalModal (.../components/globalModal/index.tsx:33:3)
    at GlobalDrawer (.../components/globalDrawer/index.tsx:25:3)
    at $4068a0fae83b6d84$export$323e4fc2fa4753fb (.../sentry/sentry/node_modules/@.../utils/dist/packages/@.../utils/src/openLink.tsx:41:8)
    at ProvideAriaRouter (.../app/utils/provideAriaRouter.tsx:17:3)
    at routeContext (.../sentry/sentry/node_modules/react-router/lib/hooks.tsx:658:26)
    at RenderErrorBoundary (.../sentry/sentry/node_modules/react-router/lib/hooks.tsx:584:5)
    at routes (.../sentry/sentry/node_modules/react-router-dom/index.tsx:760:3)
    at basenameProp (.../sentry/sentry/node_modules/react-router/lib/components.tsx:413:13)
    at fallbackElement (.../sentry/sentry/node_modules/react-router-dom/index.tsx:487:3)
    at QueryClientProvider (.../sentry/sentry/node_modules/@.../react-query/src/QueryClientProvider.tsx:30:3)
    at ThemeProvider (.../sentry/sentry/node_modules/@.../react/dist/emotion-element-48d2c2e4.cjs.dev.js:125:32)
    at .../js/sentry-test/reactTestingLibrary.tsx:75:5
    at console.captureMessage [as error] (.../sentry/sentry/node_modules/jest-fail-on-console/index.js:83:25)
    at printWarning (.../sentry/sentry/node_modules/react-dom/cjs/react-dom.development.js:86:30)
    at error (.../sentry/sentry/node_modules/react-dom/cjs/react-dom.development.js:60:7)
    at validateProperty$1 (.../sentry/sentry/node_modules/react-dom/cjs/react-dom.development.js:3757:7)
    at warnUnknownProperties (.../sentry/sentry/node_modules/react-dom/cjs/react-dom.development.js:3803:21)
    at validateProperties$2 (.../sentry/sentry/node_modules/react-dom/cjs/react-dom.development.js:3827:3)
    at validatePropertiesInDevelopment (.../sentry/sentry/node_modules/react-dom/cjs/react-dom.development.js:9541:5)
    at setInitialProperties (.../sentry/sentry/node_modules/react-dom/cjs/react-dom.development.js:9830:5)
    at finalizeInitialChildren (.../sentry/sentry/node_modules/react-dom/cjs/react-dom.development.js:10950:3)
    at completeWork (.../sentry/sentry/node_modules/react-dom/cjs/react-dom.development.js:22193:17)
    at completeUnitOfWork (.../sentry/sentry/node_modules/react-dom/cjs/react-dom.development.js:26593:16)
    at performUnitOfWork (.../sentry/sentry/node_modules/react-dom/cjs/react-dom.development.js:26568:5)
    at workLoopSync (.../sentry/sentry/node_modules/react-dom/cjs/react-dom.development.js:26466:5)
    at renderRootSync (.../sentry/sentry/node_modules/react-dom/cjs/react-dom.development.js:26434:7)
    at performSyncWorkOnRoot (.../sentry/sentry/node_modules/react-dom/cjs/react-dom.development.js:26085:20)
    at flushSyncCallbacks (.../sentry/sentry/node_modules/react-dom/cjs/react-dom.development.js:12042:22)
    at .../sentry/sentry/node_modules/react-dom/cjs/react-dom.development.js:25651:13
    at invokeTheCallbackFunction (.../sentry/sentry/node_modules/jsdom/lib/jsdom/living/generated/Function.js:19:26)
    at .../sentry/sentry/node_modules/jsdom/lib/jsdom/browser/Window.js:554:9
    at node:internal/process/task_queues:151:7
    at AsyncResource.runInAsyncScope (node:async_hooks:211:14)
    at AsyncResource.runMicrotask (node:internal/process/task_queues:148:8)
    at flushUnexpectedConsoleCalls (.../sentry/sentry/node_modules/jest-fail-on-console/index.js:48:13)
    at Object.<anonymous> (.../sentry/sentry/node_modules/jest-fail-on-console/index.js:139:7)
    at Promise.then.completed (.../sentry/sentry/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/sentry/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusHook (.../sentry/sentry/node_modules/jest-circus/build/run.js:281:40)
    at _runTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:254:5)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:121:9)
    at run (.../sentry/sentry/node_modules/jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:444:34)
    at Object.worker (.../sentry/sentry/node_modules/jest-runner/build/testWorker.js:106:12)
AlertWizard sets crash free dataset to metrics
Stack Traces | 0.317s run time 
Error: Expected test not to call console.error().

If the error is expected, test for it explicitly by mocking it out using jest.spyOn(console, 'error').mockImplementation() and test that the warning occurs.

Warning: React does not recognize the `radioSize` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `radiosize` instead. If you accidentally passed it from a parent component, remove it from the DOM element.
    at input
    at .../sentry/sentry/node_modules/@.../react/dist/emotion-element-48d2c2e4.cjs.dev.js:62:23
    at label
    at .../sentry/sentry/node_modules/@.../react/dist/emotion-element-48d2c2e4.cjs.dev.js:62:23
    at div
    at .../sentry/sentry/node_modules/@.../react/dist/emotion-element-48d2c2e4.cjs.dev.js:62:23
    at div
    at .../sentry/sentry/node_modules/@.../react/dist/emotion-element-48d2c2e4.cjs.dev.js:62:23
    at RadioPanelGroup (.../alerts/wizard/radioPanelGroup.tsx:14:3)
    at .../sentry/sentry/node_modules/@.../react/dist/emotion-element-48d2c2e4.cjs.dev.js:62:23
    at div
    at div
    at .../sentry/sentry/node_modules/@.../react/dist/emotion-element-48d2c2e4.cjs.dev.js:62:23
    at div
    at .../sentry/sentry/node_modules/@.../react/dist/emotion-element-48d2c2e4.cjs.dev.js:62:23
    at section
    at .../sentry/sentry/node_modules/@.../react/dist/emotion-element-48d2c2e4.cjs.dev.js:62:23
    at div
    at .../sentry/sentry/node_modules/@.../react/dist/emotion-element-48d2c2e4.cjs.dev.js:62:23
    at main
    at .../sentry/sentry/node_modules/@.../react/dist/emotion-element-48d2c2e4.cjs.dev.js:62:23
    at AlertWizard (.../alerts/wizard/index.tsx:37:3)
    at GlobalDrawer (.../components/globalDrawer/index.tsx:25:3)
    at $4068a0fae83b6d84$export$323e4fc2fa4753fb (.../sentry/sentry/node_modules/@.../utils/dist/packages/@.../utils/src/openLink.tsx:41:8)
    at ProvideAriaRouter (.../app/utils/provideAriaRouter.tsx:17:3)
    at routeContext (.../sentry/sentry/node_modules/react-router/lib/hooks.tsx:658:26)
    at RenderErrorBoundary (.../sentry/sentry/node_modules/react-router/lib/hooks.tsx:584:5)
    at routes (.../sentry/sentry/node_modules/react-router-dom/index.tsx:760:3)
    at basenameProp (.../sentry/sentry/node_modules/react-router/lib/components.tsx:413:13)
    at fallbackElement (.../sentry/sentry/node_modules/react-router-dom/index.tsx:487:3)
    at QueryClientProvider (.../sentry/sentry/node_modules/@.../react-query/src/QueryClientProvider.tsx:30:3)
    at ThemeProvider (.../sentry/sentry/node_modules/@.../react/dist/emotion-element-48d2c2e4.cjs.dev.js:125:32)
    at .../js/sentry-test/reactTestingLibrary.tsx:75:5
    at console.captureMessage [as error] (.../sentry/sentry/node_modules/jest-fail-on-console/index.js:83:25)
    at printWarning (.../sentry/sentry/node_modules/react-dom/cjs/react-dom.development.js:86:30)
    at error (.../sentry/sentry/node_modules/react-dom/cjs/react-dom.development.js:60:7)
    at validateProperty$1 (.../sentry/sentry/node_modules/react-dom/cjs/react-dom.development.js:3757:7)
    at warnUnknownProperties (.../sentry/sentry/node_modules/react-dom/cjs/react-dom.development.js:3803:21)
    at validateProperties$2 (.../sentry/sentry/node_modules/react-dom/cjs/react-dom.development.js:3827:3)
    at validatePropertiesInDevelopment (.../sentry/sentry/node_modules/react-dom/cjs/react-dom.development.js:9541:5)
    at setInitialProperties (.../sentry/sentry/node_modules/react-dom/cjs/react-dom.development.js:9830:5)
    at finalizeInitialChildren (.../sentry/sentry/node_modules/react-dom/cjs/react-dom.development.js:10950:3)
    at completeWork (.../sentry/sentry/node_modules/react-dom/cjs/react-dom.development.js:22193:17)
    at completeUnitOfWork (.../sentry/sentry/node_modules/react-dom/cjs/react-dom.development.js:26593:16)
    at performUnitOfWork (.../sentry/sentry/node_modules/react-dom/cjs/react-dom.development.js:26568:5)
    at workLoopSync (.../sentry/sentry/node_modules/react-dom/cjs/react-dom.development.js:26466:5)
    at renderRootSync (.../sentry/sentry/node_modules/react-dom/cjs/react-dom.development.js:26434:7)
    at performConcurrentWorkOnRoot (.../sentry/sentry/node_modules/react-dom/cjs/react-dom.development.js:25738:74)
    at flushActQueue (.../sentry/sentry/node_modules/react/cjs/react.development.js:2667:24)
    at act (.../sentry/sentry/node_modules/react/cjs/react.development.js:2582:11)
    at .../sentry/sentry/node_modules/@.../react/dist/act-compat.js:47:25
    at renderRoot (.../sentry/sentry/node_modules/@.../react/dist/pure.js:180:26)
    at Object.render (.../sentry/sentry/node_modules/@.../react/dist/pure.js:271:10)
    at render (.../js/sentry-test/reactTestingLibrary.tsx:193:14)
    at Object.<anonymous> (.../alerts/wizard/index.spec.tsx:25:37)
    at Promise.then.completed (.../sentry/sentry/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/sentry/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at _runTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:121:9)
    at run (.../sentry/sentry/node_modules/jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:444:34)
    at Object.worker (.../sentry/sentry/node_modules/jest-runner/build/testWorker.js:106:12)
    at flushUnexpectedConsoleCalls (.../sentry/sentry/node_modules/jest-fail-on-console/index.js:48:13)
    at Object.<anonymous> (.../sentry/sentry/node_modules/jest-fail-on-console/index.js:139:7)
    at Promise.then.completed (.../sentry/sentry/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/sentry/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusHook (.../sentry/sentry/node_modules/jest-circus/build/run.js:281:40)
    at _runTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:254:5)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:121:9)
    at run (.../sentry/sentry/node_modules/jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:444:34)
    at Object.worker (.../sentry/sentry/node_modules/jest-runner/build/testWorker.js:106:12)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@scttcper scttcper merged commit 87b25f4 into master Jan 14, 2025
42 checks passed
@scttcper scttcper deleted the scttcper/remove-default-props-1 branch January 14, 2025 21:47
andrewshie-sentry pushed a commit that referenced this pull request Jan 22, 2025
@scttcper @andrewshie-sentry
ref(react19): Remove various styled defaultProps (#83409)
005d8fc
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JonasBa JonasBa JonasBa approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scttcper @JonasBa