fix(widget-builder): Aggregates with no column not wiped #83410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
narsaynorath
commented
Jan 14, 2025
Comment on lines
-696
to
+713
| parameter.value ?? ('defaultValue' in parameter && parameter?.defaultValue) ?? '', | ||
| currentValue ?? ('defaultValue' in parameter && parameter?.defaultValue) ?? '', |
There was a problem hiding this comment.
Also snuck in this change. I realized that when I would update the value in count_if(transaction.duration,equals,300), the text field wouldn't update and this is why
narsaynorath
deleted the
nar/fix/widget-builder-aggregates-with-no-column-not-wiped
branch
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jan 22, 2025
Take the following scenario: - Choose the transaction dataset - select `transaction.duration` (i.e. set aggregate to None, set `transaction.duration` in the column field) - update the aggregate to `count()` The request is being made with `count(transaction_duration)` which shouldn't happen. I added a validate parameter helper that checks the parameter type, validates it, and if it's not valid then set it to the default value.
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take the following scenario:
transaction.duration(i.e. set aggregate to None, settransaction.durationin the column field)count()The request is being made with
count(transaction_duration)which shouldn't happen. I added a validate parameter helper that checks the parameter type, validates it, and if it's not valid then set it to the default value.