Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(migrations): Set the correct internal type for BoundedPositiveBigIntegerField #83412

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

wedamija
Copy link
Member

This was registering as an int and causing the incorrect migration to be generated

…IntegerField

This was registering as an int and causing the incorrect migration to be generated
@wedamija wedamija requested review from brendanhsentry and a team January 14, 2025 18:19
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 14, 2025
@wedamija wedamija enabled auto-merge (squash) January 14, 2025 18:41
@wedamija wedamija merged commit 8f11294 into master Jan 14, 2025
49 checks passed
@wedamija wedamija deleted the danf/migrations-fix-bigint branch January 14, 2025 18:48
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/db/models/fields/bounded.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #83412       +/-   ##
===========================================
+ Coverage   38.05%   87.50%   +49.45%     
===========================================
  Files        8884     9404      +520     
  Lines      497037   537209    +40172     
  Branches    21139    21139               
===========================================
+ Hits       189149   470094   +280945     
+ Misses     307537    66764   -240773     
  Partials      351      351               

andrewshie-sentry pushed a commit that referenced this pull request Jan 22, 2025
…IntegerField (#83412)

This was registering as an int and causing the incorrect migration to be
generated
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants