feat(widget-builder): Add widget dropdown for templates #83426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t/widget-builder-templates-add-dropdown
github-actions
bot
added
the
Scope: Frontend
nikkikapadia
changed the title
nikkikapadia
deleted the
nikki/feat/widget-builder-templates-add-dropdown
branch
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jan 22, 2025
I got rid of the hacky local storage way of accessing templates and put it right into the add widget button. I've turned the button into a dropdown on both preview and edit dashboard views. Now you can select which type of widget you want to add. I had to make additions to all `Add Widget` buttons (i think) but let me know if i've missed any of them. The flow is working! here's a look: https://github.com/user-attachments/assets/3339e39b-62cf-40c2-8a61-2ed9d2b470fc After this there is a few more fixes I want to implement before calling this 'done' 1. Edit the panel width for templates (make it smaller) 2. Make sure the initial preview state for the templates isn't an error
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got rid of the hacky local storage way of accessing templates and put it right into the add widget button. I've turned the button into a dropdown on both preview and edit dashboard views. Now you can select which type of widget you want to add. I had to make additions to all
Add Widgetbuttons (i think) but let me know if i've missed any of them.The flow is working! here's a look:
Screen.Recording.2025-01-14.at.2.28.35.PM.mov
After this there is a few more fixes I want to implement before calling this 'done'