ref: delete dead serializer code #83429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
cmanallen
approved these changes
Jan 14, 2025
asottile-sentry
force-pushed
the
asottile-dead-serializer-code
branch
from
6672ea3 to
d98af1c
Compare
JoshFerge
reviewed
Jan 14, 2025
| @@ -2,39 +2,6 @@ | |||
| from typing import Any, TypedDict | |||
|
|
|||
|
|
|||
| class ReleaseOptional(TypedDict, total=False): | |||
There was a problem hiding this comment.
@iamrajjoshi any idea why these aren't used anymore?
There was a problem hiding this comment.
introduced in de0cbb9 and never used
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jan 22, 2025
found via https://github.com/asottile/dead <!-- Describe your PR here. -->
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
found via https://github.com/asottile/dead