ref: standardize user param as User | RpcUser | AnonymousUser in Serializers #83436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
asottile-sentry
commented
Jan 14, 2025
| request, | ||
| request.user, |
There was a problem hiding this comment.
lol, this was just wrong -- fortunately nothing needed user in serializing this (and the one below!)
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #83436 +/- ##
=======================================
Coverage 87.53% 87.53%
=======================================
Files 9405 9405
Lines 537138 537184 +46
Branches 21140 21140
=======================================
+ Hits 470161 470214 +53
+ Misses 66626 66619 -7
Partials 351 351 |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jan 22, 2025
…alizers (#83436) a tiny step to making these more typesafe <!-- Describe your PR here. -->
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a tiny step to making these more typesafe