ref(issue-details): Remove all query params from legacy UI when no event is found. #83441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
scttcper
reviewed
Jan 14, 2025
| @@ -248,6 +253,43 @@ function useFetchGroupDetails(): FetchGroupDetailsState { | |||
| refetch: refetchGroupCall, | |||
| } = useGroup({groupId}); | |||
|
|
|||
| useEffect(() => { | |||
There was a problem hiding this comment.
can we put a TODO to delete this entire useEffect when cleaning up streamline ui
scttcper
approved these changes
Jan 14, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jan 22, 2025
…ent is found. (#83441) Adds back a portion removed in [this PR](https://github.com/getsentry/sentry/pull/82476/files#diff-a95c753ccf3abebbfb06333be0780c03f31de6cb0b8d178665b8ea24a02f00feL255-L275) that clears the query when it doesn't find an event, but only applies it when the UI is not streamlined. Now though, instead of just removing `query`, we remove everything except `project`, since if we kept any `date` params, the endpoint would still return empty for recommend/latest events. It also searches for any of those qparams to be set before triggering so when they are all removed, it won't infinitely call `navigate` -- may add a test for this just in case though.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds back a portion removed in this PR that clears the query when it doesn't find an event, but only applies it when the UI is not streamlined.
Now though, instead of just removing
query, we remove everything exceptproject, since if we kept anydateparams, the endpoint would still return empty for recommend/latest events. It also searches for any of those qparams to be set before triggering so when they are all removed, it won't infinitely callnavigate-- may add a test for this just in case though.