Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: fix typing for plugins.bases.issue{,2} #83445

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

asottile-sentry
Copy link
Member

No description provided.

@asottile-sentry asottile-sentry requested review from a team January 14, 2025 22:00
@asottile-sentry asottile-sentry requested review from a team as code owners January 14, 2025 22:00
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 14, 2025
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 85.00000% with 9 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/plugins/bases/issue.py 14.28% 6 Missing ⚠️
src/sentry/plugins/providers/repository.py 86.66% 2 Missing ⚠️
src/sentry/plugins/bases/issue2.py 96.87% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #83445       +/-   ##
===========================================
+ Coverage   51.67%   87.53%   +35.86%     
===========================================
  Files        9396     9405        +9     
  Lines      536705   537127      +422     
  Branches    21140    21140               
===========================================
+ Hits       277323   470166   +192843     
+ Misses     259031    66610   -192421     
  Partials      351      351               

@asottile-sentry asottile-sentry merged commit 8c6b4dd into master Jan 15, 2025
50 checks passed
@asottile-sentry asottile-sentry deleted the asottile-fix-types-issues-plugins branch January 15, 2025 14:59
andrewshie-sentry pushed a commit that referenced this pull request Jan 22, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants