feat(widget-builder): Create blank widget preview for templates #83509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Bundle ReportChanges will increase total bundle size by 31.05MB (100.0%) ⬆️
|
narsaynorath
approved these changes
Jan 15, 2025
nikkikapadia
deleted the
nikki/feat/widget-builder-templates-blank-preview
branch
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jan 22, 2025
Before when we didn't have a template selected the widget preview would error out. The mockup had a default or blank preview that I've implemented. Now when you open templates you will see the blank preview. I've also done some quick fixes for the draggable widget preview. TLDR customizing templates was not allowing draggable previews due to `ref` issues. Here's a before and after: | Before | After | |--------|--------| | <img width="1285" alt="image" src="https://github.com/user-attachments/assets/f288c319-dde9-4806-8d52-5ea9d542e854" /> | <img width="1296" alt="image" src="https://github.com/user-attachments/assets/137a5e16-37eb-4155-a4c6-86a9cc2d026c" /> |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before when we didn't have a template selected the widget preview would error out. The mockup had a default or blank preview that I've implemented. Now when you open templates you will see the blank preview. I've also done some quick fixes for the draggable widget preview. TLDR customizing templates was not allowing draggable previews due to
refissues.Here's a before and after: