ref(ourlogs): Add option to control breadcrumb extraction #84212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid rollout issues when turning on s4s and other environments, this will control the rate at which logs are extracted from breadcrumbs.
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #84212 +/- ##
==========================================
- Coverage 87.64% 87.64% -0.01%
==========================================
Files 9572 9574 +2
Lines 542376 542468 +92
Branches 21258 21258
==========================================
+ Hits 475375 475453 +78
- Misses 66649 66661 +12
- Partials 352 354 +2 |
JoshFerge
approved these changes
Jan 29, 2025
2 tasks
jjbayer
approved these changes
Jan 30, 2025
Co-authored-by: Joris Bayer <[email protected]>
andrewshie-sentry
pushed a commit
that referenced
this pull request
Feb 5, 2025
### Summary To avoid rollout issues when turning on s4s and other environments for the first time, this option will control the rate at which logs are extracted from breadcrumbs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To avoid rollout issues when turning on s4s and other environments for the first time, this option will control the rate at which logs are extracted from breadcrumbs.